Toutsu/GmRelayBot
1
1
Fork 0
Code Issues 18 Pull Requests 1 Actions Packages Projects Releases 85 Wiki Activity

fix(discord): resolve slash commands from interaction payload instead of gateway cache #98

Closed
Toutsu wants to merge 0 commits from fix/discord-slash-commands-guild-context into main
pull from: fix/discord-slash-commands-guild-context
merge into: Toutsu:main
Conversation 1 Commits - Files Changed -
Toutsu commented 2026-05-25 17:54:50 +03:00
Owner
Copy Link
Copy Source

Summary

Discord slash-команды /listsessions, /newsession, /reschedule возвращали ошибку "This command can only be used in a guild", даже когда вызывались внутри канала сервера.

Root cause: Context.Guild в NetCord берется из gateway client cache (cache.Guilds.GetValueOrDefault(guildId)), а не из JSON payload интеракции. После рестарта бота guild может еще не быть в кэше, и Context.Guild = null.

Fix: Используем Context.Interaction.GuildId из payload + REST API GetGuildAsync/GetGuildUserAsync для получения guild и member.

Changes

  • DiscordListSessionsCommand.cs — Context.Interaction.GuildId вместо Context.Guild.Id
  • DiscordNewSessionCommand.cs — REST запросы для guild/member, GetResolvedPermissions на RestGuild + GuildUser
  • DiscordRescheduleCommand.cs — аналогично
  • Версия синхронизирована до 3.0.5

Test plan

  • dotnet build src/GmRelay.DiscordBot — успешно
  • Полный test suite — 271/271 зеленых

Workflow

  • CI passes
  • Code review approved
  • Deployed
  • Release published
## Summary Discord slash-команды `/listsessions`, `/newsession`, `/reschedule` возвращали ошибку "This command can only be used in a guild", даже когда вызывались внутри канала сервера. **Root cause:** `Context.Guild` в NetCord берется из gateway client cache (`cache.Guilds.GetValueOrDefault(guildId)`), а не из JSON payload интеракции. После рестарта бота guild может еще не быть в кэше, и `Context.Guild` = null. **Fix:** Используем `Context.Interaction.GuildId` из payload + REST API `GetGuildAsync`/`GetGuildUserAsync` для получения guild и member. ## Changes - `DiscordListSessionsCommand.cs` — `Context.Interaction.GuildId` вместо `Context.Guild.Id` - `DiscordNewSessionCommand.cs` — REST запросы для guild/member, `GetResolvedPermissions` на `RestGuild` + `GuildUser` - `DiscordRescheduleCommand.cs` — аналогично - Версия синхронизирована до `3.0.5` ## Test plan - [x] `dotnet build src/GmRelay.DiscordBot` — успешно - [x] Полный test suite — 271/271 зеленых ## Workflow - [ ] CI passes - [ ] Code review approved - [ ] Deployed - [ ] Release published
Toutsu added 1 commit 2026-05-25 18:02:46 +03:00
fix(discord): resolve slash commands from interaction payload instead of gateway cache
PR Checks / test-and-build (pull_request) Successful in 8m46s
Details
f6d5281af8 
Context.Guild in NetCord resolves the Guild object from the gateway client cache
(cache.Guilds.GetValueOrDefault(guildId)), not from the interaction JSON payload.
After a bot restart, the guild may not yet be cached when the first slash command
arrives, causing Context.Guild to be null even though the command is invoked
inside a guild channel. This produced "This command can only be used in a guild."

Changes:
- DiscordListSessionsCommand: use Context.Interaction.GuildId instead of Context.Guild.Id
- DiscordNewSessionCommand: use Context.Interaction.GuildId + REST GetGuildAsync/GetGuildUserAsync
- DiscordRescheduleCommand: same as above
- DiscordSessionInteractionModule: same fix for button interactions (CreateInput)
- Add null guard in GetResolvedPermissions for safety
- Bump version to 3.0.5

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Toutsu force-pushed fix/discord-slash-commands-guild-context from 3305ca1070 to f6d5281af8 2026-05-25 18:02:46 +03:00 Compare
Toutsu reviewed 2026-05-25 18:12:56 +03:00
Toutsu left a comment
Author
Owner
Copy Link
Copy Source

Approved after CI fix. All issues from previous review addressed: DiscordSessionInteractionModule fixed, null guard added to GetResolvedPermissions.

Approved after CI fix. All issues from previous review addressed: DiscordSessionInteractionModule fixed, null guard added to GetResolvedPermissions.
Toutsu closed this pull request 2026-05-26 16:06:28 +03:00
Some checks are pending
PR Checks / test-and-build (pull_request) Successful in 8m46s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area:bot
Telegram bot and worker logic
 area:data
Database schema, migrations and persistence model
 area:discord
Discord bot service and Discord adapter
 area:infra
Infrastructure, runtime and deployment
 area:miniapp
Telegram Mini App dashboard
 area:platform
Platform-neutral abstractions and adapter boundaries
 area:shared
Shared domain and rendering contracts
 area:web
Blazor web dashboard
 in-progress
В работе (issue взят агентом)
 next-up
Recommended immediate backlog
 pending-approval
Ждёт согласования плана решения
 platform:discord
Discord-specific behavior or adapter work
 platform:multi
Cross-platform or platform-neutral work
 platform:telegram
Telegram-specific behavior or adapter work
 priority:p0
Critical priority
 priority:p0
Блокирующий приоритет: задача должна быть выполнена до признания решения production-ready
 priority:p1
High priority
 priority:p2
Medium priority
 priority:p3
Lower priority
 security
Security-sensitive work
 type:bug
Bug fix or corrective work
 type:chore
Maintenance and supporting work
 type:feature
New product functionality
 type:refactor
Structural change without direct feature growth
 type:test
Testing and coverage work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Toutsu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Toutsu/GmRelayBot#98
Delete Branch "fix/discord-slash-commands-guild-context"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?