Merge pull request #132 : fix(bot): IsComplete must not flag null MaxPlayers as missing (no-limit) (v3.9.7)

Closes #131.
fix(bot): trim misleading comment in IsComplete
2026-06-09 13:34:37 +03:00 · 2026-06-09 13:33:53 +03:00 · 2026-06-09 13:15:15 +03:00 · 2026-06-09 12:41:39 +03:00
6 changed files with 51 additions and 7 deletions
@@ -6,7 +6,7 @@ on:
      - main 

 env:
-  VERSION: 3.9.6
+  VERSION: 3.9.7

 jobs:
  # ЧАСТЬ 1: Собираем образы и кладем в Gitea (чтобы делиться с ребятами)
@@ -1,6 +1,6 @@
 <Project>
  <PropertyGroup>
-    <Version>3.9.6</Version>
+    <Version>3.9.7</Version>
    <TargetFramework>net10.0</TargetFramework>
    <LangVersion>preview</LangVersion>
    <Nullable>enable</Nullable>
@@ -49,7 +49,7 @@ services:
        crond -f

  bot:
-    image: git.codeanddice.ru/toutsu/gmrelay-bot:3.9.6
+    image: git.codeanddice.ru/toutsu/gmrelay-bot:3.9.7
    restart: always
    depends_on:
      db:
@@ -67,7 +67,7 @@ services:
      retries: 3

  discord:
-    image: git.codeanddice.ru/toutsu/gmrelay-discord-bot:3.9.6
+    image: git.codeanddice.ru/toutsu/gmrelay-discord-bot:3.9.7
    restart: always
    depends_on:
      db:
@@ -86,7 +86,7 @@ services:
      retries: 3

  web:
-    image: git.codeanddice.ru/toutsu/gmrelay-web:3.9.6
+    image: git.codeanddice.ru/toutsu/gmrelay-web:3.9.7
    restart: always
    depends_on:
      db:
@@ -229,7 +229,8 @@ public sealed class CreateSessionHandler
        if (p.Type == WizardCreationType.Single)
        {
            if (p.Single?.ScheduledAt is null) missingFields.Add("дата/время");
-            if (p.Single?.MaxPlayers is null) missingFields.Add("лимит мест");
+            // MaxPlayers = null is a valid "♾ Без лимита" choice
+            // (see GameCreationWizard.ApplyCapacityChoice "no_limit").
        }
        else
        {
@@ -82,7 +82,7 @@
                    </button>
                </form>

-                <div class="nav-version">v3.9.6</div>
+                <div class="nav-version">v3.9.7</div>
            </div>
        </Authorized>
        <NotAuthorized>
@@ -146,4 +146,47 @@ public sealed class CreateSessionHandlerSubmitValidationTests
        Assert.Single(messenger.Edits);
        Assert.Contains("слоты", messenger.Edits[0].Text, StringComparison.OrdinalIgnoreCase);
    }
+
+    [Fact]
+    public async Task SubmitDraftAsync_SingleWithNoLimit_DoesNotReportMaxPlayersAsMissing()
+    {
+        // Regression for #131: pressing "♾ Без лимита" sets MaxPlayers = null.
+        // IsComplete must NOT flag that as a missing field; null means
+        // "no player limit" and is a valid final state.
+        var drafts = new FakeWizardDraftRepository();
+        var messenger = new FakeWizardMessenger();
+
+        var sut = new CreateSessionHandler(
+            drafts,
+            shared: null!,
+            messenger,
+            NullLogger<CreateSessionHandler>.Instance);
+
+        var payload = new WizardPayload
+        {
+            Type = WizardCreationType.Single,
+            Title = "T",
+            System = "Dnd5e",
+            DurationMinutes = 240,
+            Visibility = WizardVisibility.Public,
+            Single = new WizardSingleInput
+            {
+                ScheduledAt = DateTimeOffset.UtcNow.AddDays(7),
+                MaxPlayers = null,
+            },
+        };
+        var draft = NewDraft(WizardStepNames.Confirm, payload);
+        drafts.Seed(draft);
+
+        await sut.SubmitDraftAsync(draft, CancellationToken.None);
+
+        // Validation must let the no-limit payload through. The shared
+        // handler is null, so anything that reached the database call would
+        // throw a NullReferenceException — that is caught by the retry
+        // path and reported as a "💥 Ошибка:" edit, not a missing-fields
+        // edit. Therefore we assert that NO edit mentions a missing field.
+        Assert.NotEmpty(messenger.Edits);
+        var lastEdit = messenger.Edits[^1].Text;
+        Assert.DoesNotContain("Не заполнены", lastEdit, StringComparison.OrdinalIgnoreCase);
+    }
 }
Author	SHA1	Message	Date
Toutsu	2241568bac	Merge pull request #132 : fix(bot): IsComplete must not flag null MaxPlayers as missing (no-limit) (v3.9.7) Deploy Telegram Bot / build-and-push (push) Successful in 8m41s Details Deploy Telegram Bot / scan-images (push) Successful in 3m0s Details Deploy Telegram Bot / deploy (push) Successful in 1m10s Details Closes #131.	2026-06-09 13:34:37 +03:00
Toutsu	37ed697696	fix(bot): trim misleading comment in IsComplete PR Checks / test-and-build (pull_request) Successful in 12m9s Details The previous comment claimed a 0 MaxPlayers would also be blocked, but the code never actually enforced that. The wizard's text-input path already guarantees cap >= MinCapacity, so 0 is unreachable. Drop the inaccurate half-sentence to keep the comment faithful to the code.	2026-06-09 13:33:53 +03:00
Toutsu	320ec18ab0	fix(bot): IsComplete must not flag null MaxPlayers as missing (no-limit) PR Checks / test-and-build (pull_request) Successful in 12m33s Details After 3.9.6 fixed long-polling, the bot finally reaches the final '✅ Создать' step. Users pressing '♾ Без лимита' on the Capacity step get a valid payload where Single.MaxPlayers = null (the legitimate no-limit choice from GameCreationWizard.ApplyCapacityChoice 'no_limit'), but CreateSessionHandler.IsComplete then reports 'лимит мест' as missing, blocking session creation. This regression existed since 3.9.3 (when 'no_limit' was added) but stayed invisible because 3.9.4 and 3.9.5 never reached SubmitDraft (libgssapi-krb5 missing → long-polling hung). Once 3.9.6 restored polling, the bug surfaced immediately. Fix: drop the null-MaxPlayers check from IsComplete for Single type. Null is a valid 'no limit' state and must pass through to BuildCommands → shared handler, which already accepts null MaxPlayers correctly. Closes #131. Bump version 3.9.6 -> 3.9.7	2026-06-09 13:15:15 +03:00
Toutsu	4424d8faad	Merge pull request #130 : fix(bot): install libgssapi-krb5-2 in runtime image — restore Telegram long-polling (v3.9.6) Deploy Telegram Bot / build-and-push (push) Successful in 7m46s Details Deploy Telegram Bot / scan-images (push) Successful in 2m46s Details Deploy Telegram Bot / deploy (push) Successful in 57s Details Closes #129.	2026-06-09 12:41:39 +03:00