feat(discord): improve UX and add source-level tests for /newsession

- DiscordNewSessionCommand: on success, renders session details via DiscordSessionBatchRenderer.Render() with embeds and action rows. - DiscordNewSessionCommand: uses Discord emoji shortcodes for error and success messages (✅, ⛔, 💥). - DiscordNewSessionHandlerTests: added 7 source-level structural tests verifying Dapper usage, NpgsqlDataSource, permission checks, platform neutrality, transaction safety, CancellationToken usage, and embed rendering in the command. Refs issue #28 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-19 12:36:17 +03:00
parent daa59335cc
commit d55003a2a9
2 changed files with 110 additions and 4 deletions
@@ -1,3 +1,4 @@
+using GmRelay.DiscordBot.Rendering;
 using NetCord.Rest;
 using NetCord.Services.ApplicationCommands;

@@ -49,19 +50,23 @@ public class DiscordNewSessionCommand : ApplicationCommandModule<SlashCommandCon
                joinLink: link,
                CancellationToken.None);

+            var (embeds, actionRows) = DiscordSessionBatchRenderer.Render(view);
            await Context.Interaction.SendResponseAsync(
-                InteractionCallback.Message("+ Session created!"));
+                InteractionCallback.Message(new InteractionMessageProperties()
+                    .WithContent(":white_check_mark: **Session created successfully!**")
+                    .WithEmbeds(embeds)
+                    .WithComponents(actionRows)));
        }
        catch (UnauthorizedAccessException ex)
        {
            await Context.Interaction.SendResponseAsync(
-                InteractionCallback.Message($"! {ex.Message}"));
+                InteractionCallback.Message($":no_entry: {ex.Message}"));
        }
        catch (Exception ex)
        {
            _logger.LogError(ex, "Failed to create session for user {UserId} in guild {GuildId}", Context.User.Id, guild.Id);
            await Context.Interaction.SendResponseAsync(
-                InteractionCallback.Message("* An error occurred while creating the session."));
+                InteractionCallback.Message(":boom: An error occurred while creating the session."));
        }
    }

@@ -1,9 +1,22 @@
-using GmRelay.DiscordBot.Features.Sessions;
+using GmRelay.DiscordBot.Features.Sessions;

 namespace GmRelay.Bot.Tests.Discord;

 public sealed class DiscordNewSessionHandlerTests
 {
+    private static string GetRepoRoot()
+    {
+        var dir = AppContext.BaseDirectory;
+        while (!string.IsNullOrEmpty(dir) && !File.Exists(Path.Combine(dir, "Directory.Build.props")))
+        {
+            dir = Directory.GetParent(dir)?.FullName;
+        }
+
+        return dir ?? throw new InvalidOperationException("Could not find repo root");
+    }
+
+    // --- Runtime tests for ParseTimeInput (static, no DB) ---
+
    [Fact]
    public void ParseTimeInput_ShouldParseDiscordDateFormat()
    {
@@ -40,4 +53,92 @@ public sealed class DiscordNewSessionHandlerTests
        Assert.False(result.IsSuccess);
        Assert.NotNull(result.Error);
    }
+
+    // --- Source-level structural tests ---
+
+    [Fact]
+    public void Handler_ShouldExist()
+    {
+        var repoRoot = GetRepoRoot();
+        var handlerPath = Path.Combine(repoRoot, "src", "GmRelay.DiscordBot", "Features", "Sessions", "DiscordNewSessionHandler.cs");
+        Assert.True(File.Exists(handlerPath), "DiscordNewSessionHandler should exist.");
+    }
+
+    [Fact]
+    public void Handler_ShouldUseDapperForDatabaseAccess()
+    {
+        var repoRoot = GetRepoRoot();
+        var handlerPath = Path.Combine(repoRoot, "src", "GmRelay.DiscordBot", "Features", "Sessions", "DiscordNewSessionHandler.cs");
+        var source = File.ReadAllText(handlerPath);
+
+        Assert.Contains("QueryAsync", source, StringComparison.Ordinal);
+        Assert.Contains("ExecuteAsync", source, StringComparison.Ordinal);
+        Assert.Contains("ExecuteScalarAsync", source, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void Handler_ShouldUseNpgsqlDataSource()
+    {
+        var repoRoot = GetRepoRoot();
+        var handlerPath = Path.Combine(repoRoot, "src", "GmRelay.DiscordBot", "Features", "Sessions", "DiscordNewSessionHandler.cs");
+        var source = File.ReadAllText(handlerPath);
+
+        Assert.Contains("NpgsqlDataSource", source, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void Handler_ShouldCheckPermissionsViaPermissionChecker()
+    {
+        var repoRoot = GetRepoRoot();
+        var handlerPath = Path.Combine(repoRoot, "src", "GmRelay.DiscordBot", "Features", "Sessions", "DiscordNewSessionHandler.cs");
+        var source = File.ReadAllText(handlerPath);
+
+        Assert.Contains("CanManageSchedule", source, StringComparison.Ordinal);
+        Assert.Contains("UnauthorizedAccessException", source, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void Handler_ShouldBePlatformNeutral()
+    {
+        var repoRoot = GetRepoRoot();
+        var handlerPath = Path.Combine(repoRoot, "src", "GmRelay.DiscordBot", "Features", "Sessions", "DiscordNewSessionHandler.cs");
+        var source = File.ReadAllText(handlerPath);
+
+        Assert.DoesNotContain("telegram_chat_id", source, StringComparison.Ordinal);
+        Assert.DoesNotContain("telegram_id", source, StringComparison.Ordinal);
+        Assert.Contains("platform = 'Discord'", source, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void Handler_ShouldUseTransactions()
+    {
+        var repoRoot = GetRepoRoot();
+        var handlerPath = Path.Combine(repoRoot, "src", "GmRelay.DiscordBot", "Features", "Sessions", "DiscordNewSessionHandler.cs");
+        var source = File.ReadAllText(handlerPath);
+
+        Assert.Contains("BeginTransactionAsync", source, StringComparison.Ordinal);
+        Assert.Contains("CommitAsync", source, StringComparison.Ordinal);
+        Assert.Contains("RollbackAsync", source, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void Handler_ShouldRespectCancellationToken()
+    {
+        var repoRoot = GetRepoRoot();
+        var handlerPath = Path.Combine(repoRoot, "src", "GmRelay.DiscordBot", "Features", "Sessions", "DiscordNewSessionHandler.cs");
+        var source = File.ReadAllText(handlerPath);
+
+        Assert.Contains("CancellationToken", source, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void Command_ShouldRenderEmbedOnSuccess()
+    {
+        var repoRoot = GetRepoRoot();
+        var commandPath = Path.Combine(repoRoot, "src", "GmRelay.DiscordBot", "Features", "Sessions", "DiscordNewSessionCommand.cs");
+        var source = File.ReadAllText(commandPath);
+
+        Assert.Contains("DiscordSessionBatchRenderer.Render", source, StringComparison.Ordinal);
+        Assert.Contains("WithEmbeds", source, StringComparison.Ordinal);
+    }
 }