Files
GmRelayBot/tests/GmRelay.Bot.Tests/Infrastructure/Database/PlatformIdentityMigrationTests.cs
T
Toutsu 542f15f2d6
PR Checks / test-and-build (pull_request) Successful in 13m48s
refactor: extract remaining Telegram handlers to platform-neutral contracts
- Extract CreateSessionHandler, ListSessionsHandler, DeleteSessionHandler,
  ExportCalendarHandler, HandleRescheduleTimeInputHandler,
  HandleRescheduleVoteHandler to GmRelay.Shared
- Add IPlatformMessenger methods: SendScheduleAsync, UpdateScheduleAsync,
  SendGroupMessageAsync with actions, CreateThreadAsync, DeleteThreadAsync
- Rewrite Telegram Bot wrappers as thin adapters delegating to shared handlers
- Rewrite DiscordRescheduleVoteHandler to use shared HandleRescheduleVoteHandler
- Update UpdateRouter with explicit type aliases for ambiguous handler names
- Add contract and source-inspection tests for extracted handlers
- Bump version 3.1.1 → 3.2.0

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-27 14:52:09 +03:00

159 lines
7.2 KiB
C#

namespace GmRelay.Bot.Tests.Infrastructure.Database;
public sealed class PlatformIdentityMigrationTests
{
[Fact]
public async Task MigrationV016_ShouldAddPlatformIdentityColumns()
{
var migration = await ReadRepositoryFileAsync("src/GmRelay.Bot/Migrations/V016__add_platform_identity.sql");
Assert.Contains("players", migration, StringComparison.Ordinal);
Assert.Contains("platform", migration, StringComparison.Ordinal);
Assert.Contains("external_user_id", migration, StringComparison.Ordinal);
Assert.Contains("external_username", migration, StringComparison.Ordinal);
Assert.Contains("game_groups", migration, StringComparison.Ordinal);
Assert.Contains("external_group_id", migration, StringComparison.Ordinal);
Assert.Contains("external_channel_id", migration, StringComparison.Ordinal);
}
[Fact]
public async Task MigrationV016_ShouldCreatePlatformMessagesTable()
{
var migration = await ReadRepositoryFileAsync("src/GmRelay.Bot/Migrations/V016__add_platform_identity.sql");
Assert.Contains("CREATE TABLE platform_messages", migration, StringComparison.Ordinal);
Assert.Contains("platform", migration, StringComparison.Ordinal);
Assert.Contains("group_id", migration, StringComparison.Ordinal);
Assert.Contains("batch_id", migration, StringComparison.Ordinal);
Assert.Contains("session_id", migration, StringComparison.Ordinal);
Assert.Contains("external_thread_id", migration, StringComparison.Ordinal);
Assert.Contains("external_message_id", migration, StringComparison.Ordinal);
Assert.Contains("purpose", migration, StringComparison.Ordinal);
}
[Fact]
public async Task MigrationV016_ShouldBackfillExistingTelegramData()
{
var migration = await ReadRepositoryFileAsync("src/GmRelay.Bot/Migrations/V016__add_platform_identity.sql");
Assert.Contains("UPDATE players", migration, StringComparison.Ordinal);
Assert.Contains("UPDATE game_groups", migration, StringComparison.Ordinal);
Assert.Contains("'Telegram'", migration, StringComparison.Ordinal);
Assert.Contains("telegram_id", migration, StringComparison.Ordinal);
Assert.Contains("telegram_chat_id", migration, StringComparison.Ordinal);
}
[Fact]
public async Task MigrationV016_ShouldNotDropLegacyTelegramColumns()
{
var migration = await ReadRepositoryFileAsync("src/GmRelay.Bot/Migrations/V016__add_platform_identity.sql");
Assert.DoesNotContain("DROP COLUMN telegram_id", migration, StringComparison.OrdinalIgnoreCase);
Assert.DoesNotContain("DROP COLUMN telegram_chat_id", migration, StringComparison.OrdinalIgnoreCase);
Assert.DoesNotContain("DROP COLUMN telegram_username", migration, StringComparison.OrdinalIgnoreCase);
Assert.DoesNotContain("DROP COLUMN gm_telegram_id", migration, StringComparison.OrdinalIgnoreCase);
}
[Fact]
public async Task Code_ShouldQueryPlayersUsingExternalUserIdFallback()
{
var createHandler = await ReadRepositoryFileAsync("src/GmRelay.Shared/Features/Sessions/CreateSession/CreateSessionHandler.cs");
Assert.Contains("external_user_id", createHandler, StringComparison.Ordinal);
}
[Fact]
public async Task Code_ShouldQueryGroupsUsingExternalGroupIdFallback()
{
var createHandler = await ReadRepositoryFileAsync("src/GmRelay.Shared/Features/Sessions/CreateSession/CreateSessionHandler.cs");
Assert.Contains("external_group_id", createHandler, StringComparison.Ordinal);
}
[Fact]
public async Task JoinSessionHandler_ShouldDualWritePlatformIdentity()
{
var handler = await ReadRepositoryFileAsync("src/GmRelay.Shared/Features/Sessions/CreateSession/JoinSessionHandler.cs");
Assert.Contains("external_user_id", handler, StringComparison.Ordinal);
Assert.Contains("external_username", handler, StringComparison.Ordinal);
Assert.Contains("platform", handler, StringComparison.Ordinal);
}
[Fact]
public async Task WebSessionService_ShouldDualWritePlatformIdentity()
{
var service = await ReadRepositoryFileAsync("src/GmRelay.Web/Services/SessionService.cs");
Assert.Contains("external_user_id", service, StringComparison.Ordinal);
Assert.Contains("external_username", service, StringComparison.Ordinal);
Assert.Contains("platform", service, StringComparison.Ordinal);
}
[Fact]
public async Task WebSessionService_ShouldAuthorizeGroupsAcrossLinkedIdentities()
{
var service = await ReadRepositoryFileAsync("src/GmRelay.Web/Services/SessionService.cs");
Assert.Contains("_ResolveLinkedPlayerIdsAsync", service, StringComparison.Ordinal);
Assert.Contains("player_id = ANY(@PlayerIds)", service, StringComparison.Ordinal);
}
[Fact]
public async Task AttendanceStatsFunction_ShouldReferenceExternalUsername()
{
var statsMigration = await ReadRepositoryFileAsync("src/GmRelay.Bot/Migrations/V012__add_attendance_stats.sql");
Assert.Contains("external_username", statsMigration, StringComparison.Ordinal);
}
[Fact]
public async Task MigrationV017_ShouldAllowPlayersWithoutLegacyTelegramId()
{
var migration = await ReadRepositoryFileAsync("src/GmRelay.Bot/Migrations/V017__allow_platform_neutral_players.sql");
Assert.Contains("ALTER TABLE players", migration, StringComparison.Ordinal);
Assert.Contains("telegram_id DROP NOT NULL", migration, StringComparison.Ordinal);
}
[Fact]
public async Task MigrationV024_ShouldDeprecateTelegramColumns()
{
var migration = await ReadRepositoryFileAsync("src/GmRelay.Bot/Migrations/V024__deprecate_telegram_columns.sql");
Assert.Contains("UPDATE players", migration, StringComparison.Ordinal);
Assert.Contains("UPDATE game_groups", migration, StringComparison.Ordinal);
Assert.Contains("DEPRECATED", migration, StringComparison.Ordinal);
Assert.Contains("calendar_subscriptions", migration, StringComparison.Ordinal);
Assert.Contains("user_platform", migration, StringComparison.Ordinal);
Assert.Contains("user_external_id", migration, StringComparison.Ordinal);
}
[Fact]
public async Task MigrationV025_ShouldBackfillRescheduleProposals()
{
var migration = await ReadRepositoryFileAsync("src/GmRelay.Bot/Migrations/V025__reschedule_proposals_telegram_external.sql");
Assert.Contains("reschedule_proposals", migration, StringComparison.Ordinal);
Assert.Contains("proposed_by_external_user_id", migration, StringComparison.Ordinal);
}
private static async Task<string> ReadRepositoryFileAsync(string relativePath)
{
var directory = new DirectoryInfo(AppContext.BaseDirectory);
while (directory is not null)
{
var candidate = Path.Combine(directory.FullName, relativePath);
if (File.Exists(candidate))
{
return await File.ReadAllTextAsync(candidate);
}
directory = directory.Parent;
}
throw new FileNotFoundException($"Could not locate repository file '{relativePath}'.");
}
}