Toutsu/GmRelayBot
1
1
Fork 0
Code Issues 18 Pull Requests 1 Actions Packages Projects Releases 85 Wiki Activity

fix(discord): use correct slash command context type in AddApplicationCommands #97

Closed
Toutsu wants to merge 0 commits from fix/discord-slash-command-registration into main
pull from: fix/discord-slash-command-registration
merge into: Toutsu:main
Conversation 2 Commits - Files Changed -
Toutsu commented 2026-05-25 17:07:03 +03:00
Owner
Copy Link
Copy Source

Summary

Discord slash-команды /newsession, /listsessions, /reschedule не появлялись в клиенте Discord, потому что AddApplicationCommands() по умолчанию регистрирует ApplicationCommandService<ApplicationCommandContext>, а наши модули наследуют ApplicationCommandModule<SlashCommandContext>. SlashCommandContext не является наследником ApplicationCommandContext в NetCord, поэтому AddModules(Assembly) никогда не находил эти модули. Команда /ping работала, так как она minimal API и не зависит от сканирования модулей.

Changes

  • src/GmRelay.DiscordBot/Program.cs — заменено AddApplicationCommands() на AddApplicationCommands<SlashCommandInteraction, SlashCommandContext>() + добавлен using NetCord.Services.ApplicationCommands
  • Версия синхронизирована до 3.0.4 в Directory.Build.props, compose.yaml, .gitea/workflows/deploy.yml, NavMenu.razor

Test plan

  • dotnet build src/GmRelay.DiscordBot/GmRelay.DiscordBot.csproj — успешно
  • Полный test suite GmRelay.Bot.Tests — 271/271 зеленых

Workflow

  • CI passes
  • Code review approved
  • Deployed
  • Release published
## Summary Discord slash-команды `/newsession`, `/listsessions`, `/reschedule` не появлялись в клиенте Discord, потому что `AddApplicationCommands()` по умолчанию регистрирует `ApplicationCommandService<ApplicationCommandContext>`, а наши модули наследуют `ApplicationCommandModule<SlashCommandContext>`. `SlashCommandContext` не является наследником `ApplicationCommandContext` в NetCord, поэтому `AddModules(Assembly)` никогда не находил эти модули. Команда `/ping` работала, так как она minimal API и не зависит от сканирования модулей. ## Changes - `src/GmRelay.DiscordBot/Program.cs` — заменено `AddApplicationCommands()` на `AddApplicationCommands<SlashCommandInteraction, SlashCommandContext>()` + добавлен `using NetCord.Services.ApplicationCommands` - Версия синхронизирована до `3.0.4` в `Directory.Build.props`, `compose.yaml`, `.gitea/workflows/deploy.yml`, `NavMenu.razor` ## Test plan - [x] `dotnet build src/GmRelay.DiscordBot/GmRelay.DiscordBot.csproj` — успешно - [x] Полный test suite `GmRelay.Bot.Tests` — 271/271 зеленых ## Workflow - [ ] CI passes - [ ] Code review approved - [ ] Deployed - [ ] Release published
Toutsu added 1 commit 2026-05-25 17:07:03 +03:00
fix(discord): use correct slash command context type in AddApplicationCommands
PR Checks / test-and-build (pull_request) Failing after 8m7s
Details
d931da37ec 
The default AddApplicationCommands() registers ApplicationCommandService<ApplicationCommandContext>,
but our modules inherit ApplicationCommandModule<SlashCommandContext>. Because SlashCommandContext
does not inherit from ApplicationCommandContext in NetCord, AddModules(typeof(Program).Assembly)
failed to discover the modules, so /newsession, /listsessions, /reschedule were never published
to Discord. Only /ping worked because it uses the minimal API route.

Fix: specify AddApplicationCommands<SlashCommandInteraction, SlashCommandContext>() so the
service matches the module context type, allowing module discovery to succeed.

Bump version to 3.0.4.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Toutsu added 1 commit 2026-05-25 17:09:06 +03:00
test: sync version assertions to 3.0.4
PR Checks / test-and-build (pull_request) Successful in 8m35s
Details
9bd5fe75c9 
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Toutsu reviewed 2026-05-25 17:24:08 +03:00
Toutsu left a comment
Author
Owner
Copy Link
Copy Source

Approved after CI fix. Root cause verified: AddApplicationCommands() registers ApplicationCommandService<ApplicationCommandContext> which cannot discover ApplicationCommandModule<SlashCommandContext> modules. The generic overload fix is correct.

Approved after CI fix. Root cause verified: `AddApplicationCommands()` registers `ApplicationCommandService<ApplicationCommandContext>` which cannot discover `ApplicationCommandModule<SlashCommandContext>` modules. The generic overload fix is correct.
Toutsu reviewed 2026-05-25 17:24:15 +03:00
Toutsu left a comment
Author
Owner
Copy Link
Copy Source

Approved.

Approved.
Toutsu closed this pull request 2026-05-26 16:06:28 +03:00
Some checks are pending
PR Checks / test-and-build (pull_request) Successful in 8m35s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area:bot
Telegram bot and worker logic
 area:data
Database schema, migrations and persistence model
 area:discord
Discord bot service and Discord adapter
 area:infra
Infrastructure, runtime and deployment
 area:miniapp
Telegram Mini App dashboard
 area:platform
Platform-neutral abstractions and adapter boundaries
 area:shared
Shared domain and rendering contracts
 area:web
Blazor web dashboard
 in-progress
В работе (issue взят агентом)
 next-up
Recommended immediate backlog
 pending-approval
Ждёт согласования плана решения
 platform:discord
Discord-specific behavior or adapter work
 platform:multi
Cross-platform or platform-neutral work
 platform:telegram
Telegram-specific behavior or adapter work
 priority:p0
Critical priority
 priority:p0
Блокирующий приоритет: задача должна быть выполнена до признания решения production-ready
 priority:p1
High priority
 priority:p2
Medium priority
 priority:p3
Lower priority
 security
Security-sensitive work
 type:bug
Bug fix or corrective work
 type:chore
Maintenance and supporting work
 type:feature
New product functionality
 type:refactor
Structural change without direct feature growth
 type:test
Testing and coverage work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Toutsu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Toutsu/GmRelayBot#97
Delete Branch "fix/discord-slash-command-registration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?