Toutsu/GmRelayBot
1
1
Fork 0
Code Issues 18 Pull Requests 1 Actions Packages Projects Releases 85 Wiki Activity

fix(discord): declare slash commands on module methods #96

Closed
Toutsu wants to merge 0 commits from codex/fix-issue-94-netcord-command-methods into main
pull from: codex/fix-issue-94-netcord-command-methods
merge into: Toutsu:main
Conversation 1 Commits - Files Changed -
Toutsu commented 2026-05-25 16:28:35 +03:00
Owner
Copy Link
Copy Source

Summary

  • Fixes issue #94 after manual Discord verification showed v3.0.2 still exposed only /ping.
  • Moves NetCord [SlashCommand] attributes from module classes to ExecuteAsync methods for /newsession, /listsessions, and /reschedule.
  • Adds tests proving NetCord discovers these commands via AddModules(assembly).
  • Bumps patch version to 3.0.3 across project, Docker tags, deploy workflow, and UI version label.

Root Cause

NetCord treats class-level [SlashCommand] on an ApplicationCommandModule<TContext> as a slash command group definition and returns before scanning method commands. Our session commands had the attributes on the class, so the module methods were not registered as standalone slash commands.

Test Plan

  • dotnet test tests\GmRelay.Bot.Tests\GmRelay.Bot.Tests.csproj --filter "FullyQualifiedName~DiscordStartupTests.DiscordSessionSlashCommands"
  • dotnet test tests\GmRelay.Bot.Tests\GmRelay.Bot.Tests.csproj --filter "FullyQualifiedName~DiscordStartupTests|FullyQualifiedName~DiscordProjectStructureTests"
  • dotnet build GM-Relay.slnx
  • dotnet test GM-Relay.slnx

Workflow

  • CI passes
  • Code review completed
  • Merged to main
  • Deployed
  • Release published
## Summary - Fixes issue #94 after manual Discord verification showed v3.0.2 still exposed only `/ping`. - Moves NetCord `[SlashCommand]` attributes from module classes to `ExecuteAsync` methods for `/newsession`, `/listsessions`, and `/reschedule`. - Adds tests proving NetCord discovers these commands via `AddModules(assembly)`. - Bumps patch version to `3.0.3` across project, Docker tags, deploy workflow, and UI version label. ## Root Cause NetCord treats class-level `[SlashCommand]` on an `ApplicationCommandModule<TContext>` as a slash command group definition and returns before scanning method commands. Our session commands had the attributes on the class, so the module methods were not registered as standalone slash commands. ## Test Plan - `dotnet test tests\GmRelay.Bot.Tests\GmRelay.Bot.Tests.csproj --filter "FullyQualifiedName~DiscordStartupTests.DiscordSessionSlashCommands"` - `dotnet test tests\GmRelay.Bot.Tests\GmRelay.Bot.Tests.csproj --filter "FullyQualifiedName~DiscordStartupTests|FullyQualifiedName~DiscordProjectStructureTests"` - `dotnet build GM-Relay.slnx` - `dotnet test GM-Relay.slnx` ## Workflow - [ ] CI passes - [ ] Code review completed - [ ] Merged to main - [ ] Deployed - [ ] Release published
Toutsu added 1 commit 2026-05-25 16:28:35 +03:00
fix(discord): declare slash commands on module methods
PR Checks / test-and-build (pull_request) Successful in 8m26s
Details
0b45aee96d
Toutsu commented 2026-05-25 16:48:13 +03:00
Author
Owner
Copy Link
Copy Source

Merged manually into main because Gitea MCP merge returned HTTP 405 for this repository. Merge commit: 9375fa45b24a7a07e4416bbe329198fa6dd8da4e.

CI PR run #238: success
Deploy main run #239: success
Release: https://git.codeanddice.ru/Toutsu/GmRelayBot/releases/tag/v3.0.3

Merged manually into `main` because Gitea MCP merge returned HTTP 405 for this repository. Merge commit: `9375fa45b24a7a07e4416bbe329198fa6dd8da4e`. CI PR run #238: success Deploy main run #239: success Release: https://git.codeanddice.ru/Toutsu/GmRelayBot/releases/tag/v3.0.3
Toutsu closed this pull request 2026-05-25 16:48:17 +03:00
Some checks are pending
PR Checks / test-and-build (pull_request) Successful in 8m26s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area:bot
Telegram bot and worker logic
 area:data
Database schema, migrations and persistence model
 area:discord
Discord bot service and Discord adapter
 area:infra
Infrastructure, runtime and deployment
 area:miniapp
Telegram Mini App dashboard
 area:platform
Platform-neutral abstractions and adapter boundaries
 area:shared
Shared domain and rendering contracts
 area:web
Blazor web dashboard
 in-progress
В работе (issue взят агентом)
 next-up
Recommended immediate backlog
 pending-approval
Ждёт согласования плана решения
 platform:discord
Discord-specific behavior or adapter work
 platform:multi
Cross-platform or platform-neutral work
 platform:telegram
Telegram-specific behavior or adapter work
 priority:p0
Critical priority
 priority:p0
Блокирующий приоритет: задача должна быть выполнена до признания решения production-ready
 priority:p1
High priority
 priority:p2
Medium priority
 priority:p3
Lower priority
 security
Security-sensitive work
 type:bug
Bug fix or corrective work
 type:chore
Maintenance and supporting work
 type:feature
New product functionality
 type:refactor
Structural change without direct feature growth
 type:test
Testing and coverage work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Toutsu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Toutsu/GmRelayBot#96
Delete Branch "codex/fix-issue-94-netcord-command-methods"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?