test(data): harden portfolio migration contract

src/GmRelay.Bot/Migrations/V029__add_completed_game_portfolios_and_reviews.sql

@@ -68,6 +68,13 @@ CREATE TABLE portfolio_game_reviews (
     UNIQUE (portfolio_game_id, author_player_id)
 );
 
+CREATE INDEX ix_portfolio_game_reviews_author
+    ON portfolio_game_reviews (author_player_id);
+
+CREATE INDEX ix_portfolio_game_reviews_moderator
+    ON portfolio_game_reviews (moderated_by_player_id)
+    WHERE moderated_by_player_id IS NOT NULL;
+
 CREATE INDEX ix_portfolio_game_reviews_public
     ON portfolio_game_reviews (portfolio_game_id, created_at DESC)
     WHERE moderation_status = 'Approved' AND publication_consent_at IS NOT NULL;

tests/GmRelay.Bot.Tests/Web/PortfolioMigrationTests.cs

@@ -6,6 +6,7 @@ public sealed class PortfolioMigrationTests
     public async Task MigrationV029_ShouldCreatePortfolioTablesAndPublicationGuards()
     {
         var migration = await ReadRepositoryFileAsync("src/GmRelay.Bot/Migrations/V029__add_completed_game_portfolios_and_reviews.sql");
+        var normalizedMigration = NormalizeSql(migration);
 
         Assert.Contains("CREATE TABLE portfolio_games", migration, StringComparison.Ordinal);
         Assert.Contains("CREATE TABLE portfolio_game_sessions", migration, StringComparison.Ordinal);
@@ -15,9 +16,23 @@ public sealed class PortfolioMigrationTests
         Assert.Contains("UNIQUE (session_id)", migration, StringComparison.Ordinal);
         Assert.Contains("UNIQUE (portfolio_game_id, author_player_id)", migration, StringComparison.Ordinal);
         Assert.Contains("CHECK (moderation_status IN ('Pending', 'Approved', 'Rejected', 'Hidden'))", migration, StringComparison.Ordinal);
-        Assert.Contains("publication_consent_at", migration, StringComparison.Ordinal);
+        Assert.Contains("CHECK (NOT is_public OR (", normalizedMigration, StringComparison.Ordinal);
+        Assert.Contains("public_slug IS NOT NULL", migration, StringComparison.Ordinal);
+        Assert.Contains("description IS NOT NULL", migration, StringComparison.Ordinal);
+        Assert.Contains("cover_storage_key IS NOT NULL", migration, StringComparison.Ordinal);
+        Assert.Contains("published_at IS NOT NULL", migration, StringComparison.Ordinal);
+        Assert.Contains("publication_consent_at TIMESTAMPTZ NOT NULL", normalizedMigration, StringComparison.Ordinal);
+        Assert.Contains("REFERENCES game_groups(id) ON DELETE CASCADE", migration, StringComparison.Ordinal);
+        Assert.Contains("REFERENCES sessions(id) ON DELETE CASCADE", migration, StringComparison.Ordinal);
+        Assert.Contains("REFERENCES players(id) ON DELETE CASCADE", migration, StringComparison.Ordinal);
+        Assert.Contains("REFERENCES players(id) ON DELETE SET NULL", migration, StringComparison.Ordinal);
         Assert.Contains("ix_portfolio_games_public", migration, StringComparison.Ordinal);
         Assert.Contains("ix_portfolio_game_reviews_public", migration, StringComparison.Ordinal);
+        Assert.Contains("WHERE moderation_status = 'Approved' AND publication_consent_at IS NOT NULL", migration, StringComparison.Ordinal);
+        Assert.Contains("ix_portfolio_game_reviews_pending", migration, StringComparison.Ordinal);
+        Assert.Contains("WHERE moderation_status = 'Pending'", migration, StringComparison.Ordinal);
+        Assert.Contains("ix_portfolio_game_reviews_author", migration, StringComparison.Ordinal);
+        Assert.Contains("ix_portfolio_game_reviews_moderator", migration, StringComparison.Ordinal);
     }
 
     [Fact]
@@ -30,6 +45,13 @@ public sealed class PortfolioMigrationTests
         Assert.DoesNotContain("physical_path", migration, StringComparison.OrdinalIgnoreCase);
     }
 
+    private static string NormalizeSql(string sql)
+    {
+        return string.Join(' ', sql.Split((char[]?)null, StringSplitOptions.RemoveEmptyEntries))
+            .Replace("( ", "(", StringComparison.Ordinal)
+            .Replace(" )", ")", StringComparison.Ordinal);
+    }
+
     private static async Task<string> ReadRepositoryFileAsync(string relativePath)
     {
         var directory = new DirectoryInfo(AppContext.BaseDirectory);