fix(data): serialize new-link publication races

2026-06-02 07:31:35 +03:00
parent 1d62f69ff0
commit ea714480d3
5 changed files with 105 additions and 10 deletions
@@ -542,6 +542,95 @@ public sealed class PortfolioMigrationPostgresTests(PortfolioMigrationPostgresFi
            parameters: new NpgsqlParameter("sessionId", seed.SessionIds[0])));
    }

+    [Fact]
+    public async Task ConcurrentNewLinkPublishAndFutureReschedule_ShouldNotCommitInvalidPublicCard()
+    {
+        var database = await fixture.CreateMigratedDatabaseAsync();
+        await using var seedConnection = await database.OpenConnectionAsync();
+        var seed = await SeedCardAsync(seedConnection, isPublic: false);
+        var rescheduledSessionId = Guid.NewGuid();
+        await ExecuteNonQueryAsync(
+            seedConnection,
+            """
+            INSERT INTO sessions (id, group_id, title, join_link, scheduled_at)
+            VALUES (@sessionId, @groupId, 'Completed Session', 'https://example.test/session', now() - interval '1 day');
+            """,
+            parameters:
+            [
+                new NpgsqlParameter("sessionId", rescheduledSessionId),
+                new NpgsqlParameter("groupId", seed.GroupId)
+            ]);
+
+        await using var rescheduleConnection = await database.OpenConnectionAsync();
+        await using var publishConnection = await database.OpenConnectionAsync();
+        await using var gateConnection = await database.OpenConnectionAsync();
+        await using var observerConnection = await database.OpenConnectionAsync();
+        await using var rescheduleTransaction = await rescheduleConnection.BeginTransactionAsync();
+        await using var publishTransaction = await publishConnection.BeginTransactionAsync();
+        await using var gateTransaction = await gateConnection.BeginTransactionAsync();
+        var reschedulePid = await GetBackendPidAsync(rescheduleConnection, rescheduleTransaction);
+        var publishPid = await GetBackendPidAsync(publishConnection, publishTransaction);
+        var gatePid = await GetBackendPidAsync(gateConnection, gateTransaction);
+        await AcquirePortfolioValidationLockAsync(gateConnection, gateTransaction);
+
+        Assert.Equal(1, await RescheduleSessionAsync(
+            rescheduleConnection,
+            rescheduleTransaction,
+            rescheduledSessionId));
+        var forceRescheduleTriggerTask = ExecuteNonQueryAsync(
+            rescheduleConnection,
+            "SET CONSTRAINTS trg_sessions_unpublish_public_portfolio_games_for_future_reschedule IMMEDIATE",
+            rescheduleTransaction);
+        await WaitUntilBlockedByAsync(observerConnection, reschedulePid, gatePid);
+
+        await ExecuteNonQueryAsync(
+            publishConnection,
+            """
+            INSERT INTO portfolio_game_sessions (portfolio_game_id, session_id)
+            VALUES (@portfolioGameId, @sessionId);
+
+            UPDATE portfolio_games
+            SET is_public = true,
+                published_at = COALESCE(published_at, now()),
+                updated_at = now()
+            WHERE id = @portfolioGameId;
+            """,
+            publishTransaction,
+            new NpgsqlParameter("portfolioGameId", seed.PortfolioGameId),
+            new NpgsqlParameter("sessionId", rescheduledSessionId));
+        var publishCommitTask = CommitAndCaptureSqlStateAsync(publishTransaction);
+        await WaitUntilBlockedByAsync(observerConnection, publishPid, gatePid);
+
+        await gateTransaction.CommitAsync().WaitAsync(CommandTimeout);
+        await forceRescheduleTriggerTask.WaitAsync(CommandTimeout);
+        await rescheduleTransaction.CommitAsync().WaitAsync(CommandTimeout);
+
+        Assert.Equal(PostgresErrorCodes.CheckViolation, await publishCommitTask.WaitAsync(CommandTimeout));
+
+        await using var verificationConnection = await database.OpenConnectionAsync();
+        Assert.False(await ExecuteScalarAsync<bool>(
+            verificationConnection,
+            "SELECT is_public FROM portfolio_games WHERE id = @portfolioGameId",
+            parameters: new NpgsqlParameter("portfolioGameId", seed.PortfolioGameId)));
+        Assert.True(await ExecuteScalarAsync<bool>(
+            verificationConnection,
+            "SELECT scheduled_at >= now() FROM sessions WHERE id = @sessionId",
+            parameters: new NpgsqlParameter("sessionId", rescheduledSessionId)));
+        Assert.Equal(0, await ExecuteScalarAsync<long>(
+            verificationConnection,
+            """
+            SELECT COUNT(*)
+            FROM portfolio_game_sessions
+            WHERE portfolio_game_id = @portfolioGameId
+              AND session_id = @sessionId
+            """,
+            parameters:
+            [
+                new NpgsqlParameter("portfolioGameId", seed.PortfolioGameId),
+                new NpgsqlParameter("sessionId", rescheduledSessionId)
+            ]));
+    }
+
    [Theory]
    [InlineData(true)]
    [InlineData(false)]