feat(#21): support selected telegram topics for schedules
PR Checks / test-and-build (pull_request) Failing after 3m18s
PR Checks / test-and-build (pull_request) Failing after 3m18s
Route new schedules to an existing forum topic when /newsession is sent inside one, create bot-owned topics only from the forum root, and keep group notifications/dashboard updates threaded to the stored topic. Persist topic ownership so deletion only removes empty bot-created topics, add topic routing tests and smoke coverage, and bump release metadata to 1.14.0.
This commit is contained in:
@@ -0,0 +1,80 @@
|
||||
using GmRelay.Bot.Infrastructure.Telegram;
|
||||
|
||||
namespace GmRelay.Bot.Tests.Infrastructure.Telegram;
|
||||
|
||||
public sealed class TelegramTopicRoutingTests
|
||||
{
|
||||
[Fact]
|
||||
public void ResolveNewScheduleDestination_UsesIncomingTopic_WhenForumCommandWasSentInsideTopic()
|
||||
{
|
||||
var destination = TelegramTopicRouting.ResolveNewScheduleDestination(
|
||||
chatIsForum: true,
|
||||
incomingMessageThreadId: 42);
|
||||
|
||||
Assert.Equal(42, destination.MessageThreadId);
|
||||
Assert.False(destination.ShouldCreateForumTopic);
|
||||
Assert.False(destination.TopicCreatedByBot);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ResolveNewScheduleDestination_CreatesBotOwnedTopic_WhenForumCommandWasSentInRoot()
|
||||
{
|
||||
var destination = TelegramTopicRouting.ResolveNewScheduleDestination(
|
||||
chatIsForum: true,
|
||||
incomingMessageThreadId: null);
|
||||
|
||||
Assert.Null(destination.MessageThreadId);
|
||||
Assert.True(destination.ShouldCreateForumTopic);
|
||||
Assert.True(destination.TopicCreatedByBot);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ResolveNewScheduleDestination_UsesPlainChat_WhenChatIsNotForum()
|
||||
{
|
||||
var destination = TelegramTopicRouting.ResolveNewScheduleDestination(
|
||||
chatIsForum: false,
|
||||
incomingMessageThreadId: 42);
|
||||
|
||||
Assert.Null(destination.MessageThreadId);
|
||||
Assert.False(destination.ShouldCreateForumTopic);
|
||||
Assert.False(destination.TopicCreatedByBot);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MissingForumTopicRightsMessage_NamesRequiredAdminRight()
|
||||
{
|
||||
Assert.Contains("admin", TelegramTopicRouting.MissingForumTopicRightsMessage, StringComparison.OrdinalIgnoreCase);
|
||||
Assert.Contains("Manage Topics", TelegramTopicRouting.MissingForumTopicRightsMessage, StringComparison.Ordinal);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("Bad Request: not enough rights to create forum topic")]
|
||||
[InlineData("Bad Request: CHAT_ADMIN_REQUIRED")]
|
||||
[InlineData("Forbidden: bot is not an administrator")]
|
||||
public void IsMissingForumTopicRightsError_MatchesAdminPermissionErrors(string apiError)
|
||||
{
|
||||
Assert.True(TelegramTopicRouting.IsMissingForumTopicRightsError(apiError));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void IsMissingForumTopicRightsError_IgnoresUnrelatedApiErrors()
|
||||
{
|
||||
Assert.False(TelegramTopicRouting.IsMissingForumTopicRightsError("Bad Request: topic name is invalid"));
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(true, 0, true)]
|
||||
[InlineData(true, 1, false)]
|
||||
[InlineData(false, 0, false)]
|
||||
public void ShouldDeleteForumTopic_DeletesOnlyBotOwnedEmptyTopic(
|
||||
bool topicCreatedByBot,
|
||||
int remainingSessionsInTopic,
|
||||
bool expected)
|
||||
{
|
||||
var shouldDelete = TelegramTopicRouting.ShouldDeleteForumTopic(
|
||||
topicCreatedByBot,
|
||||
remainingSessionsInTopic);
|
||||
|
||||
Assert.Equal(expected, shouldDelete);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user