fix(bot): IsComplete must not flag null MaxPlayers as missing (no-limit)

After 3.9.6 fixed long-polling, the bot finally reaches the final '✅ Создать' step. Users pressing '♾ Без лимита' on the Capacity step get a valid payload where Single.MaxPlayers = null (the legitimate no-limit choice from GameCreationWizard.ApplyCapacityChoice 'no_limit'), but CreateSessionHandler.IsComplete then reports 'лимит мест' as missing, blocking session creation. This regression existed since 3.9.3 (when 'no_limit' was added) but stayed invisible because 3.9.4 and 3.9.5 never reached SubmitDraft (libgssapi-krb5 missing → long-polling hung). Once 3.9.6 restored polling, the bug surfaced immediately. Fix: drop the null-MaxPlayers check from IsComplete for Single type. Null is a valid 'no limit' state and must pass through to BuildCommands → shared handler, which already accepts null MaxPlayers correctly. Closes #131. Bump version 3.9.6 -> 3.9.7
2026-06-09 13:15:15 +03:00
parent 4424d8faad
commit 320ec18ab0
6 changed files with 54 additions and 7 deletions
@@ -146,4 +146,47 @@ public sealed class CreateSessionHandlerSubmitValidationTests
        Assert.Single(messenger.Edits);
        Assert.Contains("слоты", messenger.Edits[0].Text, StringComparison.OrdinalIgnoreCase);
    }
+
+    [Fact]
+    public async Task SubmitDraftAsync_SingleWithNoLimit_DoesNotReportMaxPlayersAsMissing()
+    {
+        // Regression for #131: pressing "♾ Без лимита" sets MaxPlayers = null.
+        // IsComplete must NOT flag that as a missing field; null means
+        // "no player limit" and is a valid final state.
+        var drafts = new FakeWizardDraftRepository();
+        var messenger = new FakeWizardMessenger();
+
+        var sut = new CreateSessionHandler(
+            drafts,
+            shared: null!,
+            messenger,
+            NullLogger<CreateSessionHandler>.Instance);
+
+        var payload = new WizardPayload
+        {
+            Type = WizardCreationType.Single,
+            Title = "T",
+            System = "Dnd5e",
+            DurationMinutes = 240,
+            Visibility = WizardVisibility.Public,
+            Single = new WizardSingleInput
+            {
+                ScheduledAt = DateTimeOffset.UtcNow.AddDays(7),
+                MaxPlayers = null,
+            },
+        };
+        var draft = NewDraft(WizardStepNames.Confirm, payload);
+        drafts.Seed(draft);
+
+        await sut.SubmitDraftAsync(draft, CancellationToken.None);
+
+        // Validation must let the no-limit payload through. The shared
+        // handler is null, so anything that reached the database call would
+        // throw a NullReferenceException — that is caught by the retry
+        // path and reported as a "💥 Ошибка:" edit, not a missing-fields
+        // edit. Therefore we assert that NO edit mentions a missing field.
+        Assert.NotEmpty(messenger.Edits);
+        var lastEdit = messenger.Edits[^1].Text;
+        Assert.DoesNotContain("Не заполнены", lastEdit, StringComparison.OrdinalIgnoreCase);
+    }
 }