fix: address review feedback for health check endpoints
PR Checks / test-and-build (pull_request) Successful in 8m34s

- Install wget in Web Dockerfile for compose healthcheck
- Ensure HttpListener response is always closed in BotHealthCheckHostedService
- Use ephemeral port in Bot health check test to avoid port conflicts
- Rename NpgsqlHealthCheck test to reflect actual behavior

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
2026-05-13 11:16:58 +03:00
parent 3bea327043
commit 105b3c59d7
4 changed files with 21 additions and 7 deletions
@@ -72,10 +72,10 @@ public sealed class BotHealthCheckHostedService : IHostedService
private async Task HandleRequestAsync(HttpListenerContext context)
{
var response = context.Response;
try
{
var request = context.Request;
var response = context.Response;
if (request.Url?.AbsolutePath == "/health")
{
@@ -88,12 +88,14 @@ public sealed class BotHealthCheckHostedService : IHostedService
{
response.StatusCode = (int)HttpStatusCode.NotFound;
}
response.Close();
}
catch (Exception ex)
{
_logger.LogError(ex, "Error handling health check request");
}
finally
{
response.Close();
}
}
}
+1 -1
View File
@@ -18,7 +18,7 @@ RUN dotnet publish "GmRelay.Web.csproj" -c Release -o /app/publish /p:UseAppHost
# Stage 2: Runtime
FROM mcr.microsoft.com/dotnet/aspnet:10.0-noble AS final
WORKDIR /app
RUN apt-get update && apt-get install -y --no-install-recommends libgssapi-krb5-2 && rm -rf /var/lib/apt/lists/*
RUN apt-get update && apt-get install -y --no-install-recommends libgssapi-krb5-2 wget && rm -rf /var/lib/apt/lists/*
COPY --from=build /app/publish .
RUN mkdir -p /app/dataprotection-keys && chown -R $APP_UID:$APP_UID /app/dataprotection-keys
ENV ASPNETCORE_URLS=http://+:8080